live audio mixer #30
Merged
live audio mixer #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
reviewed
Apr 28, 2023
mickel8
requested changes
May 9, 2023
Comment on lines
+35
to
+40
| Defines how the mixer should act in the case when an overflow happens. | ||
| - If true, the wave will be scaled down, so a peak will become the maximal | ||
| value of the sample in the format. See `Membrane.AudioMixer.ClipPreventingAdder`. | ||
| - If false, overflow will be clipped to the maximal value of the sample in | ||
| the format. See `Membrane.AudioMixer.Adder`. | ||
| """, |
There was a problem hiding this comment.
This option is taken from the regular audio mixer and the description is about how particular mixers work.
|
Please don't resolve comments. They are meant to be resolved by code reviewer, accoriding to our internal contribution guide |
mickel8
requested changes
May 16, 2023
mickel8
reviewed
May 17, 2023
mickel8
approved these changes
May 17, 2023
DominikWolek
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.